Switch from local and @types/ember types to ember-source types #8717
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3958f34 to
60d6dcf
Compare
runspired
reviewed
Jul 18, 2023
runspired
reviewed
Jul 18, 2023
runspired
reviewed
Jul 18, 2023
runspired
reviewed
Jul 18, 2023
runspired
reviewed
Jul 18, 2023
Contributor
runspired
left a comment
There was a problem hiding this comment.
I'd say this is 99% mergeable 💜. left a few comments to chat through first.
BradBarnich
commented
Jul 19, 2023
runspired
reviewed
Jul 19, 2023
Contributor
|
What would be the next step once this PR is merged? Is the end goal here to port the types of |
Contributor
|
@esbanarango I think the next step is to port the DT types into the project, putting them into their respective packages within a folder named something like |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It seemed like a first step to ember-data shipping types was to use the ember-source types directly. This was a helpful to me when I was updating the @types/ember-data for ember-source types. Even if types are still shipped separately, this would make it easier to harmonize the shipped types to the internal types.
Notes for the release
not sure, seems like it is only visible internally
^ note from @runspired: this is correct. We intentionally do not ship types though this PR likely means we could ship types for @ember-data/tracking @ember-data/request @ember-data/request-utils @ember-data/rest and @ember-data/active-record starting as soon as 5.2. Would require a small cleanup pass.