Add @ember-data/legacy-compat/builders #9319
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
runspired
reviewed
Apr 5, 2024
5c63e62 to
4c78037
Compare
a3b8892 to
73fdf43
Compare
73fdf43 to
e277367
Compare
runspired
reviewed
Apr 8, 2024
runspired
reviewed
Apr 8, 2024
runspired
reviewed
Apr 8, 2024
runspired
reviewed
Apr 8, 2024
runspired
reviewed
Apr 8, 2024
runspired
approved these changes
Apr 8, 2024
Contributor
runspired
left a comment
There was a problem hiding this comment.
looks good, cleanup on doc tag ordering and pass through of generics would be good though
runspired
approved these changes
Apr 9, 2024
Baltazore
reviewed
Apr 13, 2024
| assert.strictEqual(savedPost.id, '1', 'post has correct id'); | ||
| assert.strictEqual(savedPost.name, 'Krystan rules, you drool', 'post has correct name'); | ||
| assert.true(savedPost.isDeleted, 'post isDeleted'); | ||
| assert.strictEqual(savedPost.name, 'Chris drools, Krystan rules', 'post has correct name'); |
gitKrystan
added a commit
that referenced
this pull request
Apr 29, 2024
runspired
pushed a commit
that referenced
this pull request
Apr 29, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds
@ember-data/legacy-compat/buildersmodule with builders for migrating fromstoremethods tostore.request.These builders enable you to migrate your codebase to using the correct syntax for
store.requestwhile temporarily preserving legacy behaviors. This is useful for quickly upgrading an entire app to a unified syntax while a longer incremental migration is made to shift off of adapters and serializers.Notes for the release