Improve plot item UX #1816
Improve plot item UX #1816
Conversation
emilk
left a comment
There was a problem hiding this comment.
Overall, I like the new names (PlotPoint is much better than Value).
But let's make a bytemuck opt-in - sure the official integrations all use it, but not all 3rd party does, and as I noted it makes compiling egui a lot slower.
| pub fn new(points: Vec<[f64; 2]>) -> Self { | ||
| Self::Owned(bytemuck::cast_vec(points)) | ||
| } | ||
|
|
||
| pub fn from_slice(points: &'v [[f64; 2]]) -> Self { | ||
| Self::Borrowed(bytemuck::cast_slice(points)) | ||
| } |
There was a problem hiding this comment.
bytemuck is nice, but it also makes compiling egui from scratch take ~twice as long (because of the syn crate). I'd rather keep the number of required dependencies low, so let's make bytemuck opt-in.
I think it's good to prefix these with #[cfg(feature = "bytemuck")]
There was a problem hiding this comment.
Ah good point. I removed the dependency again. I also removed PlotPoints::Borrowed for now because I couldn't find a way to to make it work with arbitrary lifetimes. Once somebody finds a way to get that working, it will make sense to add bytemuck again.
| Plot::Sigmoid => [x, sigmoid(x)], | ||
| } | ||
| }) | ||
| .collect::<Vec<_>>(), |
There was a problem hiding this comment.
Is .collect::<Vec<_>>() really more ergonomic than PlotPoints::from_iter(…) ?
There was a problem hiding this comment.
Good idea, I implemented FromIterator for PlotPoints and used this in the examples.
Co-authored-by: Emil Ernerfeldt <[email protected]>
Co-authored-by: Emil Ernerfeldt <[email protected]>
|
Closes #1843 |
Co-authored-by: Emil Ernerfeldt <[email protected]>
I like Value. The idea is that you have some metric In other words we have screen-space, plot-space, and value-space. but value-space is plot-space now. That could be misunderstood |
|
There are only two coordinate systems though, afaict: the normal screen-space point-based coordinate system of egui/epaint, and the coordinate system of the data in the plot. The reason I like "PlotPoint" is that it is descriptive (a point in plot space). "Value", on the other hand, is about as vague as it gets (rivaled only by "Data" and "Thing"). After all, what variable is not a value? |
Improves the ergonomics of creating plot items. I also tried to address emilk/egui_plot#18 by allowing the user to pass borrowed data. I however couldn't find a way to do this for non-
staticlife times. Maybe someone can find a way to add this as well.This adds
bytemuckas a dependency for theeguicrate but I figured it's okay since all integrations have it as a dependency anyway. I can remove it again otherwise.