Thanks to visit codestin.com
Credit goes to github.com

Skip to content

missing call to DeleteLocalRef in Android code #12

@GrahamAsher

Description

@GrahamAsher

This statement (as far as I understand the JNI) creates a local reference:

naett/naett.c

Line 1486 in cad8664

jobject values = call(env, headerMap, "get", "(Ljava/lang/Object;)Ljava/lang/Object;", name);

but it is not deleted, like the other local references, here:

naett/naett.c

Lines 1499 to 1500 in cad8664

(*env)->DeleteLocalRef(env, name);
(*env)->DeleteLocalRef(env, value);

The fix is to add the following statement at line 1501:

(*env)->DeleteLocalRef(env, values);

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions