Thanks to visit codestin.com
Credit goes to github.com

Skip to content

sync feature can provide misleading error messages #640

@jtiee

Description

@jtiee

Check for existing issues

  • Completed

Environment

OS: macOS Ventura 13.3.1 (a), on a Macbook M1 Pro.
Vale: 2.27.0 via direct download.

Describe the bug / provide steps to reproduce it

If I configure the Packages field in my vale.ini with a URL, and the URL happens to be incorrect or inaccessible, Vale reports:

opening zip archive for reading: creating reader: zip: not a valid zip file

This is misleading. I spent a long time trying to diagnose that error and potential problems in the ZIP file when the problem was a lack of authorization to access the ZIP archive.

When a Package URL involves a non-existent domain, Vale does report:

Get "https://example.example/style.zip": dial tcp: lookup example.example: no such host

That's useful! 4xx or 5xx HTTP errors for package downloads should be reported as such instead of blaming the ZIP file.

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions