Feat: Add Optional Custom Message to Script Match #682
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `matches` object populated by a Tengolang script can now also have an optional message per match. This way, a single script-based rule can find several similar issues while still providing a precise error message to the user on a per-match basis.
jdkato
approved these changes
Sep 14, 2023
Member
|
Thanks! I'll add some tests and then put out a new release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📖 Description
This PR implements the feature suggested in #679
The
matchesobject populated by a Tengolang script in a script based rule can now also have an optionalmessageper match. This way, a single script-based rule can find several similar issues while still providing a precise error message to the user on a per-match basis.