feat: Handle resolve urls including protocol

karlbohlmark · nchanged · commit 54f382857091 · 2018-12-13T09:25:37.000+01:00
diff --git a/src/Utils.ts b/src/Utils.ts
@@ -146,7 +146,11 @@ export function ensureAbsolutePath(userPath: string) {
 	return userPath;
 }
 export function joinFuseBoxPath(...any): string {
-	return ensureFuseBoxPath(path.join(...any));
+	let includesProtocol = any[0].includes('://');
+	let joinedPath = !includesProtocol
+		? path.join(...any)
+		: any[0].replace(/([^/])$/, '$1/') + path.join(...any.slice(1));
+	return ensureFuseBoxPath(joinedPath);
 }
 export function ensureDir(userPath: string) {
 	if (!path.isAbsolute(userPath)) {
diff --git a/src/tests/plugins/CopyPlugin.test.ts b/src/tests/plugins/CopyPlugin.test.ts
@@ -141,4 +141,21 @@ export class CssPluginTest {
 			should(result.projectContents.toString()).findString(`module.exports.default = "/static/92849cf0-hello.txt";`);
 		});
 	}
+
+	"Should copy a file with custom resolver to external domain (hash)"() {
+		return createEnv({
+			project: {
+				hash: true,
+				files: {
+					"index.ts": `require("./hello.txt")`,
+					"hello.txt": "ololo",
+				},
+				plugins: [CopyPlugin({ resolve: "https://example.com/static/", files: [".txt"] })],
+				instructions: "> index.ts",
+			},
+		}).then(result => {
+			result.shouldExistInDist("assets/92849cf0-hello.txt");
+			should(result.projectContents.toString()).findString(`module.exports.default = "https://example.com/static/92849cf0-hello.txt";`);
+		});
+	}
 }

Original file line number	Diff line number	Diff line change
`@@ -146,7 +146,11 @@ export function ensureAbsolutePath(userPath: string) {`
`146`	`146`	`return userPath;`
`147`	`147`	`}`
`148`	`148`	`export function joinFuseBoxPath(...any): string {`
`149`		`- return ensureFuseBoxPath(path.join(...any));`
	`149`	`+ let includesProtocol = any[0].includes('://');`
	`150`	`+ let joinedPath = !includesProtocol`
	`151`	`+ ? path.join(...any)`
	`152`	`+ : any[0].replace(/([^/])$/, '$1/') + path.join(...any.slice(1));`
	`153`	`+ return ensureFuseBoxPath(joinedPath);`
`150`	`154`	`}`
`151`	`155`	`export function ensureDir(userPath: string) {`
`152`	`156`	`if (!path.isAbsolute(userPath)) {`