fix: cache busting should not be used if the target is a server (#1394)

Josh Pike · nchanged · commit ae6595f1d5e0 · 2018-09-24T09:56:57.000+02:00
fixes #1393
diff --git a/src/BundleSource.ts b/src/BundleSource.ts
@@ -267,8 +267,14 @@ ${file.headerContent ? file.headerContent.join("\n") : ""}`,
 		}
 		if (this.context.sourceMapsProject || this.context.sourceMapsVendor) {
 			let sourceName = /[^\/]*$/.exec(this.context.output.filename)[0];
+			
+			if(this.context.target === "server"){
+				// cache busting should not be used if the target is a server, as it will interfere with local filesystem resolution
+				this.concat.add(null, `//# sourceMappingURL=${sourceName}.js.map`);
+			} else {
+				this.concat.add(null, `//# sourceMappingURL=${sourceName}.js.map?tm=${this.context.cacheBustPreffix}`);
+			}
 
-			this.concat.add(null, `//# sourceMappingURL=${sourceName}.js.map?tm=${this.context.cacheBustPreffix}`);
 		}
 	}
 

Original file line number	Diff line number	Diff line change
@@ -267,8 +267,14 @@ ${file.headerContent ? file.headerContent.join("\n") : ""}`,
`267`	`267`	`}`
`268`	`268`	`if (this.context.sourceMapsProject \|\| this.context.sourceMapsVendor) {`
`269`	`269`	`let sourceName = /[^\/]*$/.exec(this.context.output.filename)[0];`
	`270`	`+`
	`271`	`+ if(this.context.target === "server"){`
	`272`	`+ // cache busting should not be used if the target is a server, as it will interfere with local filesystem resolution`
	`273`	+ this.concat.add(null, `//# sourceMappingURL=${sourceName}.js.map`);
	`274`	`+ } else {`
	`275`	+ this.concat.add(null, `//# sourceMappingURL=${sourceName}.js.map?tm=${this.context.cacheBustPreffix}`);
	`276`	`+ }`
`270`	`277`
`271`		- this.concat.add(null, `//# sourceMappingURL=${sourceName}.js.map?tm=${this.context.cacheBustPreffix}`);
`272`	`278`	`}`
`273`	`279`	`}`
`274`	`280`