This repository was archived by the owner on Jun 20, 2023. It is now read-only.
fix: Support tsconfig.json with comments #1129
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nchanged
suggested changes
Feb 24, 2018
package.json
Outdated
| "wires-reactive": "^1.1.1" | ||
| }, | ||
| "dependencies": { | ||
| "@types/comment-json": "^1.1.1", |
Contributor
There was a problem hiding this comment.
Can you move this one to dev deps, please?
nchanged
approved these changes
Feb 25, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was having issues using the default
tsconfig.jsonprovided bytsc --init. This file includes comments which are not support by NodeJS's default JSON parser. I've switched to an alternative parser to support JSON comments.