This repository was archived by the owner on Jun 20, 2023. It is now read-only.
feat: log option now takes an object #1136
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…arTerminalOnBundle)
Contributor
Author
|
I'm actually not 100% convinced that the bit that clears the terminal is in the right place. Is there somewhere better for it? Really I suppose I want it to clear when a watch fires. |
Contributor
Author
|
Actually even |
nchanged
suggested changes
Mar 2, 2018
| * | ||
| * default: "universal@es5" | ||
| */ | ||
| target?: string, |
Contributor
There was a problem hiding this comment.
Oh can you add | boolean to allow just booleans
nchanged
approved these changes
Mar 19, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds some useful logging options. Note that this is not backwards compatible, so anyone using
log: trueorlog: falsewill need to change their config or will get a type error.