Swift 4.2 support + refactoring #5
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kafejo
reviewed
Oct 12, 2018
Contributor
|
@RomanPodymov thanks for your contribution. I no longer have access to manage this repo. @mkj-is is your man. |
Contributor
Author
OK, I hope he will also make a review of this pull request. |
mkj-is
reviewed
Oct 12, 2018
Contributor
mkj-is
left a comment
There was a problem hiding this comment.
Thank you for the PR, I only have some minor notes. If we do a simple clean up when updating, it would be much appreciated.
Example/Pods/Target Support Files/Pods-Sonar_Example/Pods-Sonar_Example-acknowledgements.plist
Outdated
Show resolved
Hide resolved
mkj-is
suggested changes
Oct 15, 2018
Contributor
Author
mkj-is
approved these changes
Oct 17, 2018
Contributor
mkj-is
left a comment
There was a problem hiding this comment.
Looks good to me, thank you for your contribution!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Good evening.
Thank you for your library. It is very interesting, but it was not maintained for more than year, so I decided to add support for Swift 4.2/Xcode 10 for it. Also I made some refactoring, I hope later I will refactor other parts of code.