Fix missing space in diagnostic location print (#4573)

alex-statsig · facebook-github-bot · commit 182a86647000 · 2024-01-09T14:02:34.000-08:00
Summary: Fix missing space in diagnostic location print A space was missing between the error message and location in Diagnostic.print_without_source, which made it harder to open the file from terminal output with tools like vscode. See #4571 Pull Request resolved: #4573 Test Plan: Confirmed that now the path is outputted in a format that vscode can parse out: ``` [ERROR] Compilation failed. [ERROR] Unable to run relay compiler. Error details: Failed to build: - Validation errors: - The type `Company` has no field `metric`. Did you mean `metrics`? See https://relay.dev/docs/error-reference/unknown-field/: client/components/console/pulse/details_dialog/PulseMetricDetailsDialog.tsx:465:471 ``` Note that the line range is still incorrect (it is using the character span instead of linenumber:character), but this seems much trickier to fix. Reviewed By: monicatang Differential Revision: D52635842 Pulled By: captbaritone fbshipit-source-id: fabc0aadb1b72deac2da377a44dd46afed46be60
diff --git a/compiler/crates/common/src/diagnostic.rs b/compiler/crates/common/src/diagnostic.rs
@@ -225,7 +225,7 @@ impl Diagnostic {
         let mut result = String::new();
         writeln!(
             result,
-            "{message}:{location:?}",
+            "{message}: {location:?}",
             message = &self.0.message,
             location = self.0.location
         )

Original file line number	Diff line number	Diff line change
`@@ -225,7 +225,7 @@ impl Diagnostic {`
`225`	`225`	`let mut result = String::new();`
`226`	`226`	`writeln!(`
`227`	`227`	`result,`
`228`		`- "{message}:{location:?}",`
	`228`	`+ "{message}: {location:?}",`
`229`	`229`	`message = &self.0.message,`
`230`	`230`	`location = self.0.location`
`231`	`231`	`)`