[snapshot] Add missing iPod touch to Generated Snapshot Reports #20337
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
joshdholtz
left a comment
There was a problem hiding this comment.
This looks good to me! Thank you for fixing this 😊
* master: [pilot] added the Pilot::TesterExporter class unit tests (#20394) Add device Google Pixel 5 (#20389) [action][update_info_plist] improve the plist file-path option validation check (#20356) Specify s3 object prefix (#20344) [snapshot] Add missing iPod touch to Generated Snapshot Reports (#20337) [Ruby] Ruby 2.6 is now the minimum (dropping Ruby 2.5) (#20413)
|
Hey @kylehowells 👋 Thank you for your contribution to fastlane and congrats on getting this pull request merged 🎉 Please let us know if this change requires an immediate release by adding a comment here 👍 |
|
Congratulations! 🎉 This was released as part of fastlane 2.207.0 🚀 |
Checklist
bundle exec rspecfrom the root directory to see all new and existing tests passbundle exec rubocop -ato ensure the code style is validMotivation and Context
I noticed reviewing our generated snapshot images that although the iPod touch (testing smallest screen size still supported) screenshots were generated, they were not included in the output HTML file.
Description
Added missing
iPod touch (7th generation)simulator name to the definitions used to output generated HTML files.