Peer Service Interface and Config Customizability #17
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves the
.serviceproperty fromServertoPeer, as it's technically applicable to either.Additionally, this adjusts how to use a custom class for the config (defaults to
Config) and the service (defaults toInterface). Instead of passing a custom class when callingpeer.config, the custom class must be specified at the instantiation of thePeer(or later on viapeer.config_cls) andpeer.configis no longer callable.The same customization option is available for
peer.service_clsandpeer.serviceremains uncallable, as it was when it was only available onServer.The
.configchange is a breaking change, but was deemed to be a cleaner overall solution, and is now consistent with how.servicewas being referenced.