Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@ArielLeyva
Copy link
Contributor

@ArielLeyva ArielLeyva commented Sep 24, 2025

Closes #5418

Description

What’s Changed

  1. Throttled the upload speed calculation to once every 100ms.
  2. Fixed an issue where the UI displayed Infinity MB/s when uploading many small files very quickly.

Additional Information

Previously, calculateSpeed was being called too frequently, which caused unrealistic values (e.g., Infinity MB/s) when processing batches of very small files. By introducing a 100ms throttle and averaging recent speeds, the upload speed display is now more accurate and stable.

Update

  • Added byteToKbyte helper using filesize partial for KB conversion
  • Introduced speedText computed property to replace raw MB-only speed
  • Speed is now displayed dynamically:
    • < 1 MB → shown in KB/s
    • ≥ 1 MB → shown in MB/s
  • Prevents meaningless 0.00 MB/s display
Captura de pantalla (2065)

Checklist

Before submitting your PR, please indicate which issues are either fixed or closed by this PR. See GitHub Help: Closing issues using keywords.

  • I am aware the project is currently in maintenance-only mode. See README
  • I am aware that translations MUST be made through Transifex and that this PR is NOT a translation update
  • I am making a PR against the master branch.
  • I am sure File Browser can be successfully built. See builds and development.

@hacdias hacdias force-pushed the #5418-Upload-Speeds-Shows-Infinity-MB/s branch from 3e0a1e6 to b1cb946 Compare September 25, 2025 14:52
Copy link
Member

@hacdias hacdias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@hacdias hacdias merged commit 692ca5e into filebrowser:master Sep 25, 2025
7 checks passed
@ArielLeyva ArielLeyva deleted the #5418-Upload-Speeds-Shows-Infinity-MB/s branch September 25, 2025 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

Upload Speeds Shows "Infinity MB/s"

2 participants