Update the default validation scope to Direct. #40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR changes the default validation scope from "Transitive" to "Direct" for the NuSeal package validation system. This addresses issue #32 by modifying the default behavior to validate only direct dependencies rather than transitive ones.
- Changed default validation scope from "Transitive" to "Direct"
- Updated conditional logic for package asset inclusion to explicitly check for "Transitive" mode
- Modified packaging configuration to include build assets in the standard build path
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/NuSeal/NuSealOptions.cs | Reversed default validation scope logic to make "Direct" the default |
| src/NuSeal/build/NuSeal.targets | Updated condition to explicitly check for "Transitive" scope |
| src/NuSeal/NuSeal.csproj | Changed packaging path from buildTransitive to build |
| tests/NuSeal.Tests/ConsumerParametersTests.cs | Updated test expectations to reflect new "Direct" default |
| tests/NuSeal.Tests/GenerateConsumerAssetsTaskTests.cs | Updated test data to use explicit values instead of null |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #32