Embed the PEM content in the generated assets. #44
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the system to embed PEM content directly in the generated MSBuild assets instead of extracting them from assemblies at runtime. The change shifts PEM handling from a resource-based approach to a build-time task item approach.
Key Changes:
- Introduced a new
Pemsproperty toValidateLicenseTaskthat accepts PEM data as task items - Modified the asset generation to embed PEM content directly in the generated .props files as MSBuild items
- Updated tests to reflect the new PEM handling mechanism
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/NuSeal/ValidateLicenseTask.cs | Added Pems property and validation logic for task items |
| src/NuSeal/GenerateConsumerAssetsTask.cs | Added PEM processing from task items instead of assembly resources |
| src/NuSeal/ConsumerParameters.cs | Added Pems parameter to constructor and as property |
| src/NuSeal/Assets.cs | Modified to embed PEM content in generated MSBuild assets |
| src/NuSeal/build/NuSeal.targets | Added ConsumerPems parameter to task invocation |
| tests/NuSeal.Tests/ValidateLicenseTaskTests.cs | Refactored tests to use new PEM handling approach |
| tests/NuSeal.Tests/GenerateConsumerAssetsTaskTests.cs | Updated tests for new task item PEM validation |
| tests/NuSeal.Tests/ConsumerParametersTests.cs | Added PEM parameter to constructor calls |
| tests/NuSeal.Tests/AssetsTests.cs | Updated asset generation tests for embedded PEM content |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #43