Generate unique assets per author. #38
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the NuSeal package generation system to dynamically generate unique assets per author. The changes remove stubs and assembly attributes in favor of embedding author choices and metadata directly in generated assets.
Key changes:
- Removed
NuSealProtected,NuSealValidationMode, andNuSealValidationScopeassembly attributes in favor of embedding author choices directly - Replaced stub-based asset generation with dynamic per-author asset generation using unique property and target names
- Consolidated license validation tasks into a single
ValidateLicenseTaskthat finds protected DLLs by PackageId instead of scanning assemblies
Reviewed Changes
Copilot reviewed 28 out of 28 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| ValidateLicenseTaskTests.cs | New comprehensive test suite for the unified license validation task |
| GenerateConsumerAssetsTaskTests.cs | Tests for the new dynamic asset generation task |
| Assets.cs | New utility class for generating unique MSBuild props and targets content |
| ConsumerParameters.cs | New parameter class encapsulating consumer package configuration |
| ValidateLicenseTask.cs | New unified task replacing separate direct/transitive validation tasks |
| GenerateConsumerAssetsTask.cs | New task replacing PrepareAssetsForConsumerTask with dynamic generation |
| NuSeal.targets | Updated to use new task names and parameters |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #28
Related to parent #27
NuSealProtected,NuSealValidationModeandNuSealValidationScopeassembly attributes.