feat: upgrade to Bevy 0.10. #122
Conversation
zicklag
left a comment
There was a problem hiding this comment.
Awesome, and a big thank you!! It doesn't look like it ended up too bad.
634b9c3 to
7076cd7
Compare
crates/quinn_runtime_bevy/Cargo.toml
Outdated
| async-io = "1.9" | ||
| bevy_tasks = "0.10" | ||
| futures-lite = "1" | ||
| pin-project = "1" |
There was a problem hiding this comment.
Is there a reason to make these version specifications less specific?
I'm not necessarily against it, but I was wondering if it was intentional.
As far as I understand, doing 1 is the same as 1.0.0, and that would assert that we are compatible with 1.0.0 exactly, and everything after 1.0.
That's probably true, but in order to be sure, we would have to try and build the game with version 1.0.0 exactly and make sure it still works. I've actually only ever tested the game with whatever was the latest-released version of the crate at the time I added it, so I only knew that the more specific specifier was actually tested.
|
I just pushed a commit to fix the documentation issue in CI. I think this is ready as soon as I get your feedback on the version numbers. 🚀 |
5edc14c to
9e66672
Compare
No description provided.