Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@elastic17
Copy link
Contributor

@elastic17 elastic17 commented Aug 2, 2024

Description

(1) There are misleading comments in the implementation of parameter parsing for creating environment through CLI. The specific content is shown in the following figure. Currently, the parameter EnvVersion is set to a default value of 3. When this parameter is not set when creating env, it will be set to 3. Only when manually setting -- version to 0 will this logic be followed. The current annotations do not match the current implementation and are misleading. It is recommended to delete them.
image

(2) There is redundant code in the specific implementation of updating the environment through CLI, as shown in the following figure:
image

Which issue(s) this PR fixes:

Fixes #

Testing

Checklist:

  • I ran tests as well as code linting locally to verify my changes.
  • I have done manual verification of my changes, changes working as expected.
  • I have added new tests to cover my changes.
  • My changes follow contributing guidelines of Fission.
  • I have signed all of my commits.

@elastic17 elastic17 changed the title 去除environment创建操作中的注释及更新过程中存在的冗余代码 Removing comments from the environment creation process and eliminating redundant code during the update process Aug 2, 2024
@sanketsudake sanketsudake merged commit c6beb29 into fission:main Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants