Add protocol implementation for IPPort struct and tests #1478
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 7a3fe23c46248cc71dab43bbf269c2505d81427b-PR-1478
💛 - Coveralls |
AndrewDryga
commented
Mar 1, 2023
| test "blocks overridden default client endpoint" do | ||
| FzHttp.Config.put_system_env_override(:default_client_endpoint, "1.2.3.4:1234") | ||
|
|
||
| {_admin_user, conn} = admin_conn(%{}) |
There was a problem hiding this comment.
We need live view to start after the config is overridden, otherwise, the page is already rendered when we try to set config update and there is no helper function in LiveView to re-render it (call update/2 again).
jamilbk
approved these changes
Mar 1, 2023
| test "blocks overridden default client endpoint" do | ||
| FzHttp.Config.put_system_env_override(:default_client_endpoint, "1.2.3.4:1234") | ||
|
|
||
| {_admin_user, conn} = admin_conn(%{}) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1477