Re-allow users to not select an emulator UI port. #8626
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #8621 Sorry; somehow I missed that there was a case where numbers are not required. Keeps the library's behavior of assuming that numbers are required, but allows explicitly overwriting this with a "reququired: false". This is the only value that can be provided to "required". Using type magic, the return type of number can only be defined if "required: false" is passed in.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #8626 +/- ##
==========================================
+ Coverage 51.04% 51.08% +0.03%
==========================================
Files 431 431
Lines 30986 31001 +15
Branches 6367 6368 +1
==========================================
+ Hits 15818 15837 +19
+ Misses 13752 13749 -3
+ Partials 1416 1415 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
joehan
approved these changes
May 22, 2025
TrCaM
pushed a commit
that referenced
this pull request
May 26, 2025
* Re-allow users to not select an emulator UI port. Fixes #8621 Sorry; somehow I missed that there was a case where numbers are not required. Keeps the library's behavior of assuming that numbers are required, but allows explicitly overwriting this with a "reququired: false". This is the only value that can be provided to "required". Using type magic, the return type of number can only be defined if "required: false" is passed in. * Format & changelog --------- Co-authored-by: joehan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8621
Sorry; somehow I missed that there was a case where numbers are not required. Keeps the library's behavior of assuming that numbers are required, but allows explicitly overwriting this with a "reququired: false". This is the only value that can be provided to "required". Using type magic, the return type of number can only be defined if "required: false" is passed in.
Verified manually.