"More debug options" warning when in profile mode #4075
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bkonyi
reviewed
May 6, 2022
Contributor
bkonyi
left a comment
There was a problem hiding this comment.
If we're going to show this warning, we may as well disable the checkboxes too.
packages/devtools_app/lib/src/screens/performance/performance_screen.dart
Outdated
Show resolved
Hide resolved
packages/devtools_app/lib/src/screens/performance/performance_screen.dart
Outdated
Show resolved
Hide resolved
packages/devtools_app/lib/src/screens/performance/performance_screen.dart
Outdated
Show resolved
Hide resolved
packages/devtools_app/lib/src/screens/performance/performance_screen.dart
Outdated
Show resolved
Hide resolved
Contributor
Author
sfshaza2
approved these changes
May 6, 2022
Contributor
sfshaza2
left a comment
There was a problem hiding this comment.
A few minor comments, otherwise, lgtm
packages/devtools_app/lib/src/screens/performance/performance_screen.dart
Outdated
Show resolved
Hide resolved
packages/devtools_app/lib/src/screens/performance/performance_screen.dart
Outdated
Show resolved
Hide resolved
packages/devtools_app/test/performance/performance_screen_test.dart
Outdated
Show resolved
Hide resolved
packages/devtools_app/test/performance/performance_screen_test.dart
Outdated
Show resolved
Hide resolved
Co-authored-by: Shams Zakhour (ignore Sfshaza) <[email protected]>
…vtools into performance-profile-warning
| 'These debugging options aren't available in profile mode. ' | ||
| 'To use them, run your app in debug mode.', | ||
| style: | ||
| textStyle.copyWith(color: theme.colorScheme.errorTextColor), |
Member
There was a problem hiding this comment.
since we now use this text style twice (here and in enhance_tracing.dart), add an extension method subtleErrorTextStyle to ThemeDataExtension in theme.dart. Then use that in both places.
Contributor
Author
|
Issue created to follow up on the performance options being unselected in profile mode: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3762
Adding a warning to the "More debug options" menu in the Performance tab.
This warning will show up when the connected app is not in debug mode.
Screenshots
Debug mode
Profile mode
Pre-launch Checklist
///).