Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[Inspector V2] Fix sending analytics for the V2 inspector #8512

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

[Inspector V2] Fix sending analytics for the V2 inspector #8512

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
22b9133
Fix inspector V2 metrics
elliette Nov 7, 2024
c8218a3
Resolve merge conflict
elliette Nov 7, 2024
a55b24a
Update order
elliette Nov 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions packages/devtools_app/lib/src/shared/analytics/_analytics_web.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,6 +112,7 @@ extension type GtagEventDevTools._(JSObject _) implements GtagEvent {
int? inspector_tree_controller_id, // metric12
String? android_app_id, //metric13
String? ios_bundle_id, //metric14
bool? is_v2_inspector, // metric15
});

factory GtagEventDevTools._create({
Expand Down Expand Up @@ -182,6 +183,8 @@ extension type GtagEventDevTools._(JSObject _) implements GtagEvent {
inspector_tree_controller_id: screenMetrics is InspectorScreenMetrics
? screenMetrics.inspectorTreeControllerId
: null,
is_v2_inspector:
screenMetrics is InspectorScreenMetrics ? screenMetrics.isV2 : null,
// [DeepLinkScreenMetrics]
android_app_id: screenMetrics is DeepLinkScreenMetrics
? screenMetrics.androidAppId
Expand Down Expand Up @@ -222,6 +225,7 @@ extension type GtagEventDevTools._(JSObject _) implements GtagEvent {
external int? get inspector_tree_controller_id;
external String? get android_app_id;
external String? get ios_bundle_id;
external bool? get is_v2_inspector;
}

extension type GtagExceptionDevTools._(JSObject _) implements GtagException {
Expand Down Expand Up @@ -276,6 +280,7 @@ extension type GtagExceptionDevTools._(JSObject _) implements GtagException {
int? inspector_tree_controller_id, // metric12
String? android_app_id, //metric13
String? ios_bundle_id, //metric14
bool? is_v2_inspector, // metric15
});

factory GtagExceptionDevTools._create(
Expand Down Expand Up @@ -340,6 +345,8 @@ extension type GtagExceptionDevTools._(JSObject _) implements GtagException {
inspector_tree_controller_id: screenMetrics is InspectorScreenMetrics
? screenMetrics.inspectorTreeControllerId
: null,
is_v2_inspector:
screenMetrics is InspectorScreenMetrics ? screenMetrics.isV2 : null,
// [DeepLinkScreenMetrics]
android_app_id: screenMetrics is DeepLinkScreenMetrics
? screenMetrics.androidAppId
Expand Down Expand Up @@ -380,6 +387,7 @@ extension type GtagExceptionDevTools._(JSObject _) implements GtagException {
external int? get inspector_tree_controller_id;
external String? get android_app_id;
external String? get ios_bundle_id;
external bool? get is_v2_inspector;
}

/// Whether google analytics are enabled.
Expand Down Expand Up @@ -927,6 +935,7 @@ ua.Event _uaEventFromGtagEvent(GtagEventDevTools gtagEvent) {
inspectorTreeControllerId: gtagEvent.inspector_tree_controller_id,
androidAppId: gtagEvent.android_app_id,
iosBundleId: gtagEvent.ios_bundle_id,
isV2Inspector: gtagEvent.is_v2_inspector,
);
}

Expand Down
3 changes: 3 additions & 0 deletions packages/devtools_app/web/devtools_analytics.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,9 @@ function initializeGA() {
'metric10': 'root_set_count',
'metric11': 'row_count',
'metric12': 'inspector_tree_controller_id',
'metric13': 'android_app_id',
'metric14': 'ios_bundle_id',
'metric15': 'is_v2_inspector',
},
cookie_flags: 'SameSite=None;Secure',
});
Expand Down
Loading