From e9f20a162ee44c91f7814b5094066133023533a8 Mon Sep 17 00:00:00 2001 From: stuartmorgan Date: Mon, 9 Sep 2024 11:16:21 -0400 Subject: [PATCH 1/3] Disable in app-facing --- .../example/integration_test/webview_flutter_test.dart | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/packages/webview_flutter/webview_flutter/example/integration_test/webview_flutter_test.dart b/packages/webview_flutter/webview_flutter/example/integration_test/webview_flutter_test.dart index 414471881e6..eaf9d7ea309 100644 --- a/packages/webview_flutter/webview_flutter/example/integration_test/webview_flutter_test.dart +++ b/packages/webview_flutter/webview_flutter/example/integration_test/webview_flutter_test.dart @@ -568,7 +568,8 @@ Future main() async { }); }, // Scroll position is currently not implemented for macOS. - skip: Platform.isMacOS); + // Flakes on iOS: https://github.com/flutter/flutter/issues/154826 + skip: Platform.isMacOS || Platform.isIOS); group('NavigationDelegate', () { const String blankPage = ''; From eb893ef0a339892e35f1d52bfc58ad1fc9e7f002 Mon Sep 17 00:00:00 2001 From: stuartmorgan Date: Mon, 9 Sep 2024 11:17:24 -0400 Subject: [PATCH 2/3] Disable in implementation package --- .../example/integration_test/legacy/webview_flutter_test.dart | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/packages/webview_flutter/webview_flutter_wkwebview/example/integration_test/legacy/webview_flutter_test.dart b/packages/webview_flutter/webview_flutter_wkwebview/example/integration_test/legacy/webview_flutter_test.dart index 4ddecc87e4e..f6bf750071d 100644 --- a/packages/webview_flutter/webview_flutter_wkwebview/example/integration_test/legacy/webview_flutter_test.dart +++ b/packages/webview_flutter/webview_flutter_wkwebview/example/integration_test/legacy/webview_flutter_test.dart @@ -893,7 +893,8 @@ Future main() async { }); }, // Scroll position is currently not implemented for macOS. - skip: Platform.isMacOS); + // Flakes on iOS: https://github.com/flutter/flutter/issues/154826 + skip: Platform.isMacOS || Platform.isIOS); group('NavigationDelegate', () { const String blankPage = ''; From b81cfe17abf36f7cc58a1dd1dccc6e57e280258e Mon Sep 17 00:00:00 2001 From: stuartmorgan Date: Mon, 9 Sep 2024 12:06:25 -0400 Subject: [PATCH 3/3] Missed test --- .../example/integration_test/webview_flutter_test.dart | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/packages/webview_flutter/webview_flutter_wkwebview/example/integration_test/webview_flutter_test.dart b/packages/webview_flutter/webview_flutter_wkwebview/example/integration_test/webview_flutter_test.dart index b2915ea4403..6f9256687df 100644 --- a/packages/webview_flutter/webview_flutter_wkwebview/example/integration_test/webview_flutter_test.dart +++ b/packages/webview_flutter/webview_flutter_wkwebview/example/integration_test/webview_flutter_test.dart @@ -808,7 +808,8 @@ Future main() async { }); }, // Scroll position is currently not implemented for macOS. - skip: Platform.isMacOS); + // Flakes on iOS: https://github.com/flutter/flutter/issues/154826 + skip: Platform.isMacOS || Platform.isIOS); group('NavigationDelegate', () { const String blankPage = '';