Add option to configure service monitor for flyte scheduler #6558
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Bito Automatic Review Skipped - Draft PR |
machichima
reviewed
Aug 8, 2025
charts/flyte-core/templates/flytescheduler/service-monitor.yaml
Outdated
Show resolved
Hide resolved
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #6558 +/- ##
=======================================
Coverage 58.69% 58.69%
=======================================
Files 938 938
Lines 71690 71690
=======================================
+ Hits 42079 42080 +1
+ Misses 26419 26418 -1
Partials 3192 3192
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
pingsutw
previously approved these changes
Aug 9, 2025
|
LGTM, thank you. Mind rebasing the PR? |
Signed-off-by: Jason Parraga <[email protected]>
Co-authored-by: Nary Yeh <[email protected]> Signed-off-by: Jason Parraga <[email protected]>
Signed-off-by: Jason Parraga <[email protected]>
pingsutw
approved these changes
Aug 9, 2025
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking issue
Closes #6557
Why are the changes needed?
It is helpful to have service monitors so that prometheus metrics can be scraped and used in dashboards for observability.
What changes were proposed in this pull request?
Adds the option to render a service monitor for flyte scheduler
How was this patch tested?
Tested in our production environment
Check all the applicable boxes
Related PRs
Docs link
Summary by Bito
This pull request introduces a new feature for configuring a service monitor for the Flyte scheduler, enhancing observability through Prometheus metrics. It includes a ServiceMonitor and service definition in the Helm chart, along with updates to shared secrets in manifest files for improved security.