Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Revert std::malloc/std::free to global malloc/free (#4569) #4570

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 10, 2025
+5 −4
Merged

Revert std::malloc/std::free to global malloc/free (#4569) #4570

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ce271d3
Revert std::malloc/std::free to global malloc/free
rohitsutreja Oct 10, 2025
f6e5de3
use stdlib.h for include rather than cstdlib.h
rohitsutreja Oct 10, 2025
3e80182
apply clang-format
rohitsutreja Oct 10, 2025
13b47b1
Fix formatting to match clang-format 17
rohitsutreja Oct 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions include/fmt/format.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,10 +41,11 @@
#include "base.h"

#ifndef FMT_MODULE
# include <stdlib.h> // malloc, free

# include <cmath> // std::signbit
# include <cstddef> // std::byte
# include <cstdint> // uint32_t
# include <cstdlib> // std::malloc, std::free
# include <cstring> // std::memcpy
# include <limits> // std::numeric_limits
# include <new> // std::bad_alloc
Expand Down Expand Up @@ -744,12 +745,12 @@ template <typename T> struct allocator : private std::decay<void> {

auto allocate(size_t n) -> T* {
FMT_ASSERT(n <= max_value<size_t>() / sizeof(T), "");
T* p = static_cast<T*>(std::malloc(n * sizeof(T)));
T* p = static_cast<T*>(malloc(n * sizeof(T)));
if (!p) FMT_THROW(std::bad_alloc());
return p;
}

void deallocate(T* p, size_t) { std::free(p); }
void deallocate(T* p, size_t) { free(p); }

constexpr friend auto operator==(allocator, allocator) noexcept -> bool {
return true; // All instances of this allocator are equivalent.
Expand Down
2 changes: 1 addition & 1 deletion include/fmt/std.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -198,7 +198,7 @@ auto write_demangled_name(OutputIt out, const std::type_info& ti) -> OutputIt {
int status = 0;
size_t size = 0;
std::unique_ptr<char, void (*)(void*)> demangled_name_ptr(
abi::__cxa_demangle(ti.name(), nullptr, &size, &status), &std::free);
abi::__cxa_demangle(ti.name(), nullptr, &size, &status), &free);

string_view demangled_name_view;
if (demangled_name_ptr) {
Expand Down