Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@JSCU-CNI
Copy link
Contributor

@JSCU-CNI JSCU-CNI commented Aug 5, 2025

This PR restructures the tests folder of the flow.record project. The main goal is to make the tests more organized and structured.

@codecov
Copy link

codecov bot commented Aug 5, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.00%. Comparing base (9775ddb) to head (85cf70d).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #175      +/-   ##
==========================================
+ Coverage   82.25%   83.00%   +0.74%     
==========================================
  Files          34       34              
  Lines        3652     3600      -52     
==========================================
- Hits         3004     2988      -16     
+ Misses        648      612      -36     
Flag Coverage Δ
unittests 83.00% <ø> (+0.74%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tests/adapters/__init__.py -> tests/adapter/__init__.py

Maybe nicer to keep it the same as the flow.record module it's for.

Comment applies for almost every directory.

@Schamper Schamper requested a review from yunzheng August 5, 2025 14:23
@JSCU-CNI JSCU-CNI requested a review from Schamper August 6, 2025 09:20
Copy link
Member

@Schamper Schamper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack from me but I'd like to @yunzheng to have the final approval.

Copy link
Member

@yunzheng yunzheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yunzheng yunzheng merged commit 556fef9 into fox-it:main Aug 11, 2025
25 checks passed
@JSCU-CNI JSCU-CNI deleted the restructure-tests-folder branch August 27, 2025 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants