Yes - the files themselves are also being referenced by the CMS (Craft) by slug, and those slugs need to be alphanumeric identifiers (no dashes.)

I will update doc.js too, I don't see anything in the Doc class's _label method that would require access to the whole config object.

Maybe a better question is - what does this hurt? I believe it just improves the the label generation, but doesn't change what files Fractal looks at, handles, etc.

I updated doc.js to work with this change. I believe the config.label check might be redundant to what's being done in entity.js's initEntity, but I left it, it won't hurt anything being there.

Again - we're using fractal with twig files we're sharing with another system where slugs can't contain dashes, and while everything works as is, this change makes the labels shown in Fractal show up "Like This" instead of "Likethis" by default. I looked for a way to override the _label method via a collection config file, but I don't think that's possible, and you're already using titlize() - it's just sending the original name to titlize() instead of a lowercased one.

Thanks for this. I'll try to find time to take a look at this again sometime this week. It needs a bit of manual testing, since I don't believe these parts of the codebase are covered by any tests.

Thanks, looks good! Sorry for the delay, forgot this :) I'll try to get this merged once GitHub Actions starts working properly again.

@khamer I have no idea why GitHub doesn't allow me to run the workflows or merge main in to fix the out-of-dateness. Would you mind filing the PR again? Thanks.

@mihkeleidast Sure, but if you'd like, check this one once more - I pulled all the subsequent upstream commits to my fork, so it might let you merge cleanly now. If not, I'll just make a new PR.

Oh cool, the "Approve and Run" button appeared now!

@khamer do you have any idea why the diff isn't clean? 🤔

Hrm, I'm not, but reset my main branch to upstream and cherrypicked just my two commits and now the diff looks clean, and files changed on github shows the right two instead of twelve.

Thanks, looks good now!