Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Incorrect eslint/prettier config in project generator #2535

@akash1810

Description

@akash1810

The project generator does not configure eslint to fail on Prettier errors. This means inconsistent quote marks, spacing, etc are never caught. Specifically, the package.json is missing the eslint-plugin-prettier dependency.

We should either:

  • Fail the lint step on Prettier errors
  • OR remove Prettier entirely

See https://github.com/guardian/apps-anomaly-detection/pull/10 for a worked example of the former.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions