Thanks to visit codestin.com
Credit goes to github.com

Skip to content
This repository was archived by the owner on Sep 8, 2021. It is now read-only.

Conversation

@mxdvl
Copy link
Contributor

@mxdvl mxdvl commented Oct 20, 2020

What does this change?

Follow-up on #29.
Special is not exported, and therefore cannot be used as a value in image-rendering.

See guardian/image-rendering#71.

How can we measure success?

All the relevant types are exported.

@mxdvl mxdvl requested a review from JamieB-gu October 20, 2020 11:05
Copy link
Contributor

@JamieB-gu JamieB-gu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, presumably we can't do Theme.SpecialReport?

cc @webb04

@mxdvl
Copy link
Contributor Author

mxdvl commented Oct 20, 2020

I tried it and somehow it didn't work. Maybe in the conversion from enum to type?

@webb04
Copy link
Contributor

webb04 commented Oct 20, 2020

Thanks @mxdvl I was just opening this PR too!

@JamieB-gu
Copy link
Contributor

I tried it and somehow it didn't work. Maybe in the conversion from enum to type?

Yeah very likely. I think you lose the enum lookup once it's compounded into a union type. Theme isn't an enum, it's just a "normal" type.

@mxdvl
Copy link
Contributor Author

mxdvl commented Oct 20, 2020

Brilliant @webb04—do you want to handle the NPM release?

@webb04
Copy link
Contributor

webb04 commented Oct 20, 2020

Sure could you bump the package.json and package-lock.json versions in this PR?

Co-Authored-By: Jamie Webb <[email protected]>
@webb04 webb04 merged commit da18ca1 into main Oct 20, 2020
@JamieB-gu JamieB-gu mentioned this pull request Dec 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants