Refactor IScope and ExecutionScope for cleaner context handling #727
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moved special context data (such as topology, 'each', and temporary output keys) from ExecutionScope's SpecialContext to direct variables and default methods in IScope. Removed unused or redundant methods, updated file handling to use new keys, and simplified variable and attribute management. This refactoring improves code clarity, thread safety, and maintainability, and addresses issues with variable pollution and context duplication.
|
contains a fix for #725 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved special context data (such as topology, 'each', and temporary output keys) from ExecutionScope's SpecialContext to direct variables and default methods in IScope. Removed unused or redundant methods, updated file handling to use new keys, and simplified variable and attribute management. This refactoring improves code clarity, thread safety, and maintainability, and addresses issues with variable pollution and context duplication.