Thanks to visit codestin.com
Credit goes to github.com

Skip to content
This repository was archived by the owner on Jun 6, 2025. It is now read-only.
This repository was archived by the owner on Jun 6, 2025. It is now read-only.

AreIn broken when single collection given #299

Closed
#300
Closed
AreIn broken when single collection given#299
#300
Assignees
t92549
Labels
bugConfirmed or suspected bug
Milestone
v2.5.1
@t92549

Description

@t92549
t92549
opened on Oct 28, 2022

Due to a change in the constructor to add the boolean flag, now when a single collection is provided, the varargs constructor is used which puts the collection inside another collection:

koryphe/core/src/main/java/uk/gov/gchq/koryphe/impl/predicate/AreIn.java

Lines 55 to 62 in 9ccb3b0

public AreIn(final Collection<?> allowedValues, final boolean nullOrEmptyAllowedValuesAccepted) {
this.allowedValues = allowedValues;
this.nullOrEmptyAllowedValuesAccepted = nullOrEmptyAllowedValuesAccepted;
}
public AreIn(final Object... allowedValues) {
this.allowedValues = Sets.newHashSet(allowedValues);
}

Another constructor must be added which can take a single collection

Metadata

Metadata

Assignees

Labels

bugConfirmed or suspected bug

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions