Change location of test_examples and test together with notebooks #1583
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1583 +/- ##
===========================================
- Coverage 91.11% 80.31% -10.79%
===========================================
Files 108 102 -6
Lines 10364 10419 +55
===========================================
- Hits 9442 8367 -1075
- Misses 922 2052 +1130
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
643258d to
9a4ffe4
Compare
|
@SaitejaUtpala, do you see a better way of doing this? I don't really like that if... |
.github/workflows/test.yml
Outdated
| python-version: [3.8] | ||
| geomstats-backend : ['autograd','numpy','pytorch','tensorflow'] | ||
| test-folder : ['tests/tests_geomstats/' , 'tests/test_notebooks.py'] | ||
| test-folder : ['tests/tests_geomstats/' , 'scripts'] |
There was a problem hiding this comment.
maybe test-folder should be renamed, since "scripts" is not a folder?
There was a problem hiding this comment.
ah your comment made me realize that the better way to go may be to create a folder test_scripts and move there both test files, so that the workflow code becomes much simpler. What do you think?
There was a problem hiding this comment.
@LPereira95 Definitely, great idea! Especially since we want, eventually, to have a common folder for the examples/notebooks themselves 🎉
I think what you said is good idea, have separate folder for the test files of examples and notebooks. |
9a4ffe4 to
0bc97e8
Compare
Moves test_examples to main tests folder and tests
notebooksandexamplestogether in a test workflow called "scripts".Reasoning: notebooks and examples are script-like code. I think they should be tested together (or, at least, examples should not be tested within tests_geomstats, as it is of a different nature - e.g. they only check if it runs, they do not validate the results).