Correct number of samples for VectorSpace.random_tangent_vec
#1990
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luisfpereira
approved these changes
Apr 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When there are multiple basepoints, both implementations of
random_tangent_vec(the implementations inmanifold.pyandbase.py) should now check thatn_samplesmatches the number of basepoints. If the values do not match, then in casen_samples == 1(default option), it resets it to be equal to the number of basepoints. Otherwise an error is raised.Docstrings have been updated to clarify that the vectors generated have no statistical value.
Issue
Fixes #1989 insofar as the bug is no longer present. The reference to uniformity of direction understated the difficulty of that problem, so it should probably be ignored.