-
Notifications
You must be signed in to change notification settings - Fork 2
Open
Labels
medium priorityImportant but not urgent, implement soonImportant but not urgent, implement soonv2.0Should be implemented in PROOF v2.0Should be implemented in PROOF v2.0
Description
It'd be nice to test with the latest few versions of Cromwell, e.g., https://github.com/broadinstitute/cromwell/releases/tag/87 came out in May, and it'd be nice to test this pkg with 86 and 87 at least.
For that to work easily, i'd like to make it so that tests could be run both:
- with real http requests w/o manually doing so (right now it can take quite a while for a workflow to be available after submitting a job, so we have to sleep a while before running some other function to get some info about that job)
- with vcr
Maybe it would work to somehow detect if we're inside a vcr::use_cassette block and vcr is turned off or on and behave accordingly, all in vcr::use_cassette block:
- vcr is turned on & fixture IS NOT present: sleep/wait to make sure workflow/job info is available after
cromwell_submit_batchcalls - vcr is turned on & fixture IS present: no need to sleep/wait
- vcr is turned off: sleep/wait after
cromwell_submit_batchcalls
The sleep/wait above could just be a Sys.sleep, or could be a retry situation with some backoff, or just same time gaps between each call until we get a 200 response
Once this is working, then idea is to have a matrix approach in the github actions yml file to test under different cromwell versions
Metadata
Metadata
Assignees
Labels
medium priorityImportant but not urgent, implement soonImportant but not urgent, implement soonv2.0Should be implemented in PROOF v2.0Should be implemented in PROOF v2.0