Php 8.2 8.3 support #384
Php 8.2 8.3 support #384
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for PHP 8.2 and 8.3 while updating the SDK version to 4.4.1. The changes extend PHP version compatibility and improve the testing workflow for newer PHP versions.
- Updates SDK version from 4.4.0 to 4.4.1
- Adds PHP 8.2 and 8.3 support to composer requirements
- Consolidates GitHub Actions workflow for testing multiple PHP versions
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/Constants.php | Updates SDK version constant to 4.4.1 |
| composer.json | Adds PHP 8.2 to supported versions and updates package version |
| README.md | Updates documentation with new version number |
| examples/doc-scan/app/Http/Controllers/HomeController.php | Comments out brand ID configuration |
| .github/workflows/tests.yaml | Refactors workflow to test PHP 8.2, 8.3, and 8.4 in a unified job |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| "license": "MIT", | ||
| "require": { | ||
| "php": "^7.4 || ^8.0 || ^8.1 || ^8.4", | ||
| "php": "^7.4 || ^8.0 || ^8.1 || ^8.2 || ^8.4", |
There was a problem hiding this comment.
PHP 8.3 support is missing from the version constraint. The PR title mentions PHP 8.3 support, but it's not included in the composer.json requirements.
| "php": "^7.4 || ^8.0 || ^8.1 || ^8.2 || ^8.4", | |
| "php": "^7.4 || ^8.0 || ^8.1 || ^8.2 || ^8.3", |
| - uses: actions/checkout@v4 | ||
|
|
||
| - uses: shivammathur/setup-php@2.9.0 | ||
| - uses: shivammathur/setup-php@v2 |
There was a problem hiding this comment.
| with: | ||
| php-version: ${{ matrix.php-version }} | ||
| # Optional: Add extensions if needed, for example: | ||
| # extensions: mbstring, intl, gd |
There was a problem hiding this comment.
[nitpick] Commented-out configuration example should be removed. This adds unnecessary clutter to the workflow file without providing functional value.
| # extensions: mbstring, intl, gd |
No description provided.