Thanks to visit codestin.com
Credit goes to github.com

Skip to content

traces/tracing feature are inconsistently defined and used #154

@z0w13

Description

@z0w13

There's both cfg(feature = "traces") and cfg(feature = "tracing") which are both the same feature as far as I can tell.

This works fine when enabling the traces feature as it creates the implicit tracing feature as its dependency

Ideally the feature would be defined as traces = ["dep:tracing"] and not an an implicit feature, unless I'm missing why you'd want both traces/tracing as features? Also, the feature check in the source files would consistently use traces.

I ran into this because I accidentally enabled tracing instead of traces and got some confusing compilation errors.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions