Fixes / enhancements to gsParaviewCollection #604
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is so that they show up as unique entries in the paraview multiblock inspector and they can be shown/hidden independently.
For backwards compatibility issues with older submodules.
It was ambiguous for the compiler due to the same name and arguments. Added a comment with an explanatory comment, that will help when adapting older codes.
filiatra
approved these changes
Apr 21, 2023
filiatra
approved these changes
Apr 24, 2023
filiatra
added a commit
that referenced
this pull request
Sep 7, 2023
* NEW - module system using module download at configure time (not using git submodules) - module gsMSplines that allows to incorporate general spline spaces over multipatch geometry - module gsOptimizer for solving optimization problems, featuring gradient descent, HLBFGS, etc - initial module gsPreCICE - python bindings using pybind11 for a basic subset of G+Smo - interface and boundary integrals are added to gsExprAssembler - unrefinement functions added to hierarchical splines - Krylov solvers gsBiCgStab and gsMinResQLP added - p-multigrid method added - Converting meshes to linear multipatches added (#592) - add gsParaviewDataSet and gsParaviewCollection (#604) for better interaction to Paraview (#572) - new mesh class using halfedges - new domain parameterization techniques (#624) - Newton-Cotes (commit 8ff2ee1) and patch-wise (#435) quadrature rules - Handling of boundary labels in gsMultiPatch XML reads (#591) * IMPROVED - optimize for achitecture scripts - Expresesion assembler is greatly improved, including handling non-linear problems - Several new geometries added in the gsNurbsCreator - CI tests on various platforms, improved docker support - OpenCascade for CAD file format I/O - Spectra eigenvalue solvers - gsIeti module - Haussdorf distance added in gsGeometry (#611) * FIXED - bug fix in gsTensorNurbs::insertKnot() (#589) - namespace problem when G+Smo is used aside to other Eigen library versions - fixed I/O from Parasolid and 3dm * API - Minimum C++ version compatibility is now C++11 - gsMultiBasis uses the full NURBS basis by default (commit 1a5ff6f) - Add small functions needed for the gsStructuralAnalysis and gsKLShell - Several API changes in expressions - Eigen library version used is now 3.4.0 - ExprTk library updated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull requests can only be merged after at least one review (and
approval) from @gismo/admins.
Code submitted to the stable branch should be clean, well-documented
and free of bugs.
Please consider the following checklist before issuing a pull
request:
you'd like us to include them?
List of changes:
Brought back
gsParaviewCollection::addTimestep()asGISMO_DEPRECATEDfor compatibility with older codes. The same could not be done forgsParaviewCollection::addPart(), because it caused ambiguity for the compiler. Instead a detailed comment on how to go about updating older codes to the new syntax has been added.Assertions have been added to various places, to make it a little less susceptible to user error.
Every
<DataSet>xml tag, gets a uniquenameattribute. This ensures that when using the Paraview MultiBlock Inspector, the visibility of each patch can be controlled independently.