Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Comment on binary and deleted files in a pull request #536

@github-product-roadmap

Description

@github-product-roadmap

Summary

While reviewing a pull request, users can comment on binary files (like images), deleted files, renamed files, and make general comments about a source file without attaching it to a specific line. This helps improve code quality and the review experience by ensuring conversations happen as close to the change as possible. It also ensures conversations stay with the change as updates are made to the pull request.

image

Intended Outcome

  1. Improve code quality by allowing users to comment on files that couldn't be commented on before
  2. Reduce overall review time

How will it work?

  1. A user (A) opens a pull request that changes various files, and inadvertently deletes a file
  2. A different user (B) is requested to review and navigates to the Files Changed tab
  3. User B notices the deletion and clicks the + (add comment) button next to the deleted file
  4. User B adds a comment "Please double-check that this file should be deleted" and submits their review
  5. User A reviews the comments, notices the comment about the deleted file, and replies with "Good catch. Fixing!"
  6. User A pushes a change that reverts the deletion and clicks Resolve conversation to mark the conversation as resolved

Metadata

Metadata

Assignees

No one assigned

    Labels

    allProduct SKU: AllcloudAvailable on CloudgaFeature phase: Generally availablepull requestsFeature: Github Pull RequestsserverAvailable on ServershippedShipped

    Type

    No type

    Projects

    Status

    No status

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions