-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Closed
Labels
allProduct SKU: AllProduct SKU: AllcloudAvailable on CloudAvailable on CloudgaFeature phase: Generally availableFeature phase: Generally availablepull requestsFeature: Github Pull RequestsFeature: Github Pull RequestsserverAvailable on ServerAvailable on ServershippedShippedShipped
Description
Summary
While reviewing a pull request, users can comment on binary files (like images), deleted files, renamed files, and make general comments about a source file without attaching it to a specific line. This helps improve code quality and the review experience by ensuring conversations happen as close to the change as possible. It also ensures conversations stay with the change as updates are made to the pull request.
Intended Outcome
- Improve code quality by allowing users to comment on files that couldn't be commented on before
- Reduce overall review time
How will it work?
- A user (A) opens a pull request that changes various files, and inadvertently deletes a file
- A different user (B) is requested to review and navigates to the Files Changed tab
- User B notices the deletion and clicks the
+(add comment) button next to the deleted file - User B adds a comment "Please double-check that this file should be deleted" and submits their review
- User A reviews the comments, notices the comment about the deleted file, and replies with "Good catch. Fixing!"
- User A pushes a change that reverts the deletion and clicks Resolve conversation to mark the conversation as resolved
Metadata
Metadata
Assignees
Labels
allProduct SKU: AllProduct SKU: AllcloudAvailable on CloudAvailable on CloudgaFeature phase: Generally availableFeature phase: Generally availablepull requestsFeature: Github Pull RequestsFeature: Github Pull RequestsserverAvailable on ServerAvailable on ServershippedShippedShipped
Type
Projects
Status
No status