Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix template path in update-agent-context.sh #341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 18, 2025
Merged

Fix template path in update-agent-context.sh #341

merged 1 commit into from
Sep 18, 2025

Conversation

@TheArKaID
Copy link
Contributor

@TheArKaID TheArKaID commented Sep 18, 2025

The if check is checking in the $REPO_ROOT/.specify/template/....., but the next cp commands has a different path. It makes the process failed immediately:

$ ./.specify/scripts/bash/update-agent-context.sh copilot "Some message here"
=== Updating agent context files for feature 001-i-am-building ===
sed: -e expression #1, char 28: Invalid preceding regular expression
sed: -e expression #1, char 31: Invalid preceding regular expression
sed: -e expression #1, char 18: Invalid preceding regular expression
sed: -e expression #1, char 23: Invalid preceding regular expression
Updating GitHub Copilot context file: ...SomePath/.github/copilot-instructions.md
Creating new GitHub Copilot context file...
cp: cannot stat 'SomePath/templates/agent-file-template.md': No such file or directory

@TheArKaID
Fix template path in update-agent-context.sh
ebd99bc 
The `if` check is checking in the `$REPO_ROOT/.specify/template/.....`, but the next `cp` commands has a different path
@TheArKaID TheArKaID requested a review from localden as a code owner September 18, 2025 13:48
Copilot AI review requested due to automatic review settings September 18, 2025 13:48
Copilot AI reviewed Sep 18, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes a path inconsistency in the update-agent-context.sh script where the if condition checks for a template file in one path but the cp command uses a different path, causing the script to fail.

  • Corrects the file path in the cp command to match the path used in the if condition check

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@localden localden merged commit fb9bc61 into github:main Sep 18, 2025
@TheArKaID TheArKaID deleted the patch-1 branch September 20, 2025 18:04
jellydn pushed a commit to jellydn/spec-kit that referenced this pull request Sep 30, 2025
@localden
Merge pull request github#341 from TheArKaID/patch-1
a751bfc 
Fix template path in update-agent-context.sh
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@localden localden localden approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@TheArKaID @localden