Allow specifying trim option in URL composure and thumbor-url. #128
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
16 tests failed with this. Can you take a look? I REALLY want to accept this! |
Contributor
Author
|
Sure. |
Contributor
Author
|
I think I got it now. I'm not able to run the tests locally here so we'll have to wait and see what travis has to say about it. |
Contributor
Author
|
Travis says go! :) |
heynemann
added a commit
that referenced
this pull request
Sep 27, 2012
Allow specifying trim option in URL composure and thumbor-url.
Member
|
Thanks a LOT man! Job very well done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.