Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@gcirne
Copy link
Contributor

@gcirne gcirne commented Oct 29, 2012

Fixes broken build caused by pull request #132.

To make it easier to review, here is a rundown of the changes in this pull request:

  • Fixes 3 vows failing with UnicodeEncodeError by calling encode('utf-8') in FileStorage's path_on_filesystem method. (Not sure if this will have unintended side effects. It would be nice if someone could pay special attention to this).
  • Installs opencv from ubuntu packages. Building from source was taking too long and Travis builds were timing out.
  • Removes deprecated import in app.py.
  • Adds missing python-magic dependency.

@heynemann
Copy link
Member

Very very nice! Thanks a lot, man!

heynemann added a commit that referenced this pull request Oct 29, 2012
Fixes broken build caused by pull request #132.
@heynemann heynemann merged commit ed54f1d into thumbor:master Oct 29, 2012
@nhuray
Copy link
Contributor

nhuray commented Nov 4, 2012

@gcirne Thanks a lot man to fix my pull request.

@gcirne
Copy link
Contributor Author

gcirne commented Nov 4, 2012

@nhuray Sure, no problem!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants