[Thumbor] reply 204 on every HEAD method #197
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Can you verify why the build is failing? Cheers, |
Contributor
Author
|
Finally I found out ... https://github.com/rafaelcaricio/tornado_pyvows/blob/master/tornado_pyvows/context.py#L220 :) will make some PR :) |
Member
|
Released in 3.13.1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nginx reverse HTTP service does not provide (out of the box) method to check health on upstream services.
It only do periodically HEAD requests on the / given its configuration.
In thumbor HEAD method is not implemented resulting in 405 method not allowed.
I just added a basic implementation of head in handler that only reply "204 no content" on every requests. so that nginx service should be happy.