Refactor root path registration logic #11
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed the redundant 'set' flag from rootRegistered and updated the logic to simplify root path handling. This change ensures that middleware is correctly applied to all routes, including the root, by converting "/" patterns to "/{$}".
Additional tests were added to verify the behavior of root and catch-all handling, custom not found handlers, and concurrent request management.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR simplifies somewhat confusing logic to handle catch-all routes. The most noticeable result is the ability to keep catch-all route handling (i.e., middleware on unregistered routes) and 404 handling in parallel to the registered root handler. It also removes the redundant 'set' flag from rootRegistered and updates the logic to clarify root path handling. To achive it, registered "/" route (pattertn) converted to "/{$}" internally.
Additional tests were added to verify the behavior of root and catch-all handling, custom not found handlers, and concurrent request management.