Thanks to visit codestin.com
Credit goes to github.com

Skip to content

What does CL mean in this context? #5

@stevenlee87

Description

@stevenlee87

https://github.com/gocn/styleguide/blob/532543056d5e604178e250e96c739b6646d1f116/content/zh/docs/02-guide.md

“scope of the CL in question”
"it is appropriate for the author to clean up the existing codebase in the same CL"
“perform a refactor in advance of the current CL”

If the local style disagrees with the style guide but the readability impact is limited to one file, it will generally be surfaced in a code review for which a consistent fix would be outside the scope of the CL in question. At that point, it is appropriate to file a bug to track the fix.

If a change would worsen an existing style deviation, expose it in more API surfaces, expand the number of files in which the deviation is present, or introduce an actual bug, then local consistency is no longer a valid justification for violating the style guide for new code. In these cases, it is appropriate for the author to clean up the existing codebase in the same CL, perform a refactor in advance of the current CL, or find an alternative that at least does not make the local problem worse.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions