-
Notifications
You must be signed in to change notification settings - Fork 28
Closed
Labels
enhancementImprovement to existing feature or Goblet in generalImprovement to existing feature or Goblet in general
Description
Normal deploys have the iam policy set in a try except to continue if the deploying SA lacks permissions to set iam policies
ie: https://github.com/goblet/goblet/blob/main/goblet/handlers/handler.py#L56
However for Jobs, it kills the deploy
https://github.com/goblet/goblet/blob/main/goblet/handlers/scheduler.py#L143
would it be okay to similarly put a try catch block around this one as well?
anovis
Metadata
Metadata
Assignees
Labels
enhancementImprovement to existing feature or Goblet in generalImprovement to existing feature or Goblet in general