Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[Jobs] Set IAM Policy #495

@brianhlee

Description

@brianhlee

Normal deploys have the iam policy set in a try except to continue if the deploying SA lacks permissions to set iam policies
ie: https://github.com/goblet/goblet/blob/main/goblet/handlers/handler.py#L56
However for Jobs, it kills the deploy
https://github.com/goblet/goblet/blob/main/goblet/handlers/scheduler.py#L143
would it be okay to similarly put a try catch block around this one as well?

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementImprovement to existing feature or Goblet in general

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions