Add command-line params in web launcher for server timeouts #267
Conversation
Summary of ChangesHello @kdroste-google, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces enhanced flexibility for the web launcher by making server timeouts configurable. Previously, these timeouts were fixed, but now they can be dynamically set via new command-line parameters. This change allows for more granular control over the server's behavior, enabling administrators to fine-tune responsiveness and resource management according to specific operational requirements. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces command-line parameters for configuring server timeouts (writeTimeout, readTimeout, idleTimeout) in the web launcher. The changes are well-implemented, replacing hardcoded values with configurable ones from the webConfig struct, which are populated via new command-line flags. My review includes a suggestion to also add ReadHeaderTimeout for more granular control over server behavior, which would involve small additions to the config struct, flag parsing, and server initialization.
cmd/launcher/web/web.go
Outdated
|
|
||
| fs := flag.NewFlagSet("web", flag.ContinueOnError) | ||
| fs.IntVar(&config.port, "port", 8080, "Localhost port for the server") | ||
| fs.DurationVar(&config.writeTimeout, "write-timeout", 15*time.Second, "Server write timeout (i.e. '10s', '2m')") |
There was a problem hiding this comment.
Let's add the comments to the flags:
- Explaining what is read/write timeouts exactly do (sometimes it could be confusing what's for read and what's for write).
- Explaining better which time format is expected (as it's a time.Duration it can be 1h or 200ms). We can e.g. add (
as in time.Duration format). Let's see if it can be sufficiently short.
There was a problem hiding this comment.
+1, also be explicit about the default values.
There was a problem hiding this comment.
Ad 1. added short explanations
Ad 2. referred to time.ParseDuration
There was a problem hiding this comment.
Default values are shown when you request CLI help, but also (in an ugly way) when server starts
No description provided.