Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add command-line params in web launcher for server timeouts #267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 13, 2025
Merged

Add command-line params in web launcher for server timeouts #267

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bc276d2
Add command-line params in web launcher for server timeouts
kdroste-google Nov 12, 2025
5fd7e2d
Added comments
kdroste-google Nov 12, 2025
b3f27ec
Merge remote-tracking branch 'origin/main' into webTimeouts
kdroste-google Nov 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions cmd/launcher/web/web.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,10 @@ import (

// webConfig contains parameters for launching web server
type webConfig struct {
port int
port int
writeTimeout time.Duration
readTimeout time.Duration
idleTimeout time.Duration
}

// webLauncher can launch web server
Expand Down Expand Up @@ -175,9 +178,9 @@ func (w *webLauncher) Run(ctx context.Context, config *launcher.Config) error {

srv := http.Server{
Addr: fmt.Sprintf(":%v", fmt.Sprint(w.config.port)),
WriteTimeout: time.Second * 15,
ReadTimeout: time.Second * 15,
IdleTimeout: time.Second * 60,
WriteTimeout: w.config.writeTimeout,
ReadTimeout: w.config.readTimeout,
IdleTimeout: w.config.idleTimeout,
Handler: router,
}

Expand All @@ -201,6 +204,9 @@ func NewLauncher(sublaunchers ...Sublauncher) launcher.SubLauncher {

fs := flag.NewFlagSet("web", flag.ContinueOnError)
fs.IntVar(&config.port, "port", 8080, "Localhost port for the server")
fs.DurationVar(&config.writeTimeout, "write-timeout", 15*time.Second, "Server write timeout (i.e. '10s', '2m' - see time.ParseDuration for details) - for writing the response after reading the headers & body")
fs.DurationVar(&config.readTimeout, "read-timeout", 15*time.Second, "Server read timeout (i.e. '10s', '2m' - see time.ParseDuration for details) - for reading the whole request including body")
fs.DurationVar(&config.idleTimeout, "idle-timeout", 60*time.Second, "Server idle timeout (i.e. '10s', '2m' - see time.ParseDuration for details) - for waiting for the next request (only when keep-alive is enabled)")

return &webLauncher{
config: config,
Expand Down