Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

complexity_benchmark is failing with a pretty cryptic error to me.

66: BM_Complexity_O_N/2048         D:/a/benchmark/benchmark/test/output_test_helper.cc:116: CheckCase: Check `TC.match_rule != MR_Next' failed. Expected line "BM_Complexity_O_N_RMS                              7 %            25 %    " to match regex "^%rms_name %rms %rms[ ]*$"
66:     actual regex string "^BM_Complexity_O1_RMS [ ]*[0-9]+ % [ ]*[0-9]+ %[ ]*$"
66:     started matching near: BM_Complexity_O_N_RMS                              7 %            25 %    
66:                 11826 ns        15625 ns         1000

https://github.com/google/benchmark/actions/runs/7540451018/job/20525988749?pr=1739#step:6:5222

I don't think it might ever be affected by the PR. Can anyone please suggest what to do?

complexity_benchmark is failing with a pretty cryptic error to me.

66: BM_Complexity_O_N/2048         D:/a/benchmark/benchmark/test/output_test_helper.cc:116: CheckCase: Check `TC.match_rule != MR_Next' failed. Expected line "BM_Complexity_O_N_RMS                              7 %            25 %    " to match regex "^%rms_name %rms %rms[ ]*$"
66:     actual regex string "^BM_Complexity_O1_RMS [ ]*[0-9]+ % [ ]*[0-9]+ %[ ]*$"
66:     started matching near: BM_Complexity_O_N_RMS                              7 %            25 %    
66:                 11826 ns        15625 ns         1000

https://github.com/google/benchmark/actions/runs/7540451018/job/20525988749?pr=1739#step:6:5222

I don't think it might ever be affected by the PR. Can anyone please suggest what to do?

this is generally flaky, unfortunately. don't worry about it.

@dmah42 ah, so it won't break the merge process then? Ok, then it looks like my role is over here and I presume it should merge automatically. Thanks for a quick review!

thank you!